fix(@angular/cli): apply default to array types#30943
Merged
Merged
Conversation
alan-agius4
added
action: review
alan-agius4
force-pushed
the
default-array-json
branch
3 times, most recently
from
ce21277 to
902b44c
Compare
This commit fixes an issue where the `default` option was not being applied to `array` type options in yargs. This seemingly minor change required refactoring in some tests, which revealed that a `.coerce` validation was incorrectly throwing an error on failure. The validation logic was moved to a `.check` to ensure proper error handling and prevent unexpected failures.
alan-agius4
force-pushed
the
default-array-json
branch
from
902b44c to
2656f1a
Compare
hybrist
approved these changes
Aug 18, 2025
hybrist
added
action: merge
Collaborator
Author
|
The changes were merged into the following branches: main, 20.1.x, 20.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the
defaultoption was not being applied toarraytype options in yargs.This seemingly minor change required refactoring in some tests, which revealed that a
.coercevalidation was incorrectly throwing an error on failure. The validation logic was moved to a.checkto ensure proper error handling and prevent unexpected failures.